[Piglit] [PATCH 5/7] ARB_texture_view: Test for rendering various targets in texture view

Brian Paul brianp at vmware.com
Fri Oct 25 23:51:11 CEST 2013


On 10/25/2013 10:41 AM, Jon Ashburn wrote:
> RE your comment:
>> +    config.window_width = 128;
>> +    config.window_height = 128;
>
> "Is 128 special?  Can you just go with the defaults?  In the past we've
> had trouble on Windows when the width is < 130 or so pixels.  Long story. "
>
>
> 128 isn't special  and I could use a larger number (>130). However,
> since a line is drawn diagonally across the full screen and sampled in
> its middle by this test, certain width and height combinations  fail.
> The default values  work but I am worried about the user overiding  the
> default value (not sure how that behaves). Other option is to make the
> test  more robust to varying  window width and heights rather than
> fixing the window width and height to a value that samples correctly.

OK, if you pick a size like 200x200 or 256x256 we should be OK.  People 
seldom resize piglit windows.

-Brian




More information about the Piglit mailing list