[Piglit] Patches needing to be integrated

[Jose Fonseca]

cmake patches look good AFAICT.

Reviewed-by: Jose Fonseca <jfonseca at vmware.com>

Jose

----- Original Message -----
> I submitted a couple of patches that still have not been applied to the
> piglit git repository so I figure It would be a good idea to bring up the
> fixes now...
> 
> ==================================
> [Piglit] [PATCH 1/8] cmake: fix out of tree Installation and package
> generation.
> http://lists.freedesktop.org/archives/piglit/2013-September/007572.html
> 
> This patch is designed to fix the problem of the packages not including ANY
> generated tests when using out of tree build. This is a somewhat major
> problem because not everyone builds piglit in-source. Some people build
> piglit out of tree. Currently the installation expects you to be building
> in-tree and this is wrong.
> 
> The variable CMAKE_BINARY_DIR equals CMAKE_SOURCE_DIR when building in tree,
> but when you build the source out of tree the packaging script finds no
> tests because it only looks in the source tree. When you build out of tree
> the generated tests appear in the cmake_binary_dir folder.
> 
> ==================================
> [Piglit] [PATCH 2/8] cmake: add *.geom to the list of installed files.
> http://lists.freedesktop.org/archives/piglit/2013-September/007573.html
> [Piglit] [PATCH 3/8] cmake: add *.cl to the list of installed generated
> tests.
> http://lists.freedesktop.org/archives/piglit/2013-September/007574.html
> 
> These two patches simply add the missing files that are required for testing
> OpenCL and OpenGL Geometry shaders to the list of installed files.
> 
> 
> ==================================
> [Piglit] [PATCH 5/8] cmake: Increase minimum version from 2.6 to 2.8.
> http://lists.freedesktop.org/archives/piglit/2013-September/007576.html
> 
> I know this change was contested, and this is a minor change that is aimed at
> politely reminding users on windows and OSX that CMake 2.6 is old and that
> they need to update their systems because the last release in this series
> was May 2009. For users on linux, This is already a build requirement
> because waffle requires cmake 2.8 to even compile.
> 
> ==================================
> [Piglit] [PATCH 6/8] config.h.in : add define for HAVE_STRNDUP
> http://lists.freedesktop.org/archives/piglit/2013-October/007584.html
> 
> This fixes compile problems on numerous systems that already define and
> implement strndup.
> 
> ==================================
> [Piglit] [PATCH 7/8] piglit-util-gl-common: Add Function to clear extensions
> list.
> http://lists.freedesktop.org/archives/piglit/2013-September/007578.html
> [Piglit] [PATCH 8/8] util/waffle: reinitialize extensions
> http://lists.freedesktop.org/archives/piglit/2013-September/007579.html
> 
> These two patches have already been reviewed previously Chad [2] early last
> month and the suggested changes where applied.
> 
> 
> [1] Kitware Wiki - CMake Useful Variables
> http://www.cmake.org/Wiki/CMake_Useful_Variables
> 
> [2] [Piglit] [PATCH v2 5/5] util/waffle: reinitialize extensions
> http://lists.freedesktop.org/archives/piglit/2013-September/007166.html
> 
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
>