[Piglit] [PATCH 11/13] framework/summary.py: add crashed page.

[Dylan Baker]

On Thursday, October 31, 2013 09:48:07 AM Kenney Phillis wrote:
> Sometimes a user just wants to be able to painlessly get a visual on what
> crashed. ---
>  framework/summary.py |    9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/framework/summary.py b/framework/summary.py
> index f5af627..0105bf0 100644
> --- a/framework/summary.py
> +++ b/framework/summary.py
> @@ -345,7 +345,8 @@ class Summary:
>          self.fractions = {}
>          self.totals = {}
>          self.tests = {'all': set(), 'changes': set(), 'problems': set(),
> -                      'skipped': set(), 'regressions': set(), 'fixes':
> set()} +                      'skipped': set(), 'regressions': set(),
> 'fixes': set(), +                      'crashed': set()}
> 

Could you called it 'crashes' instead of 'crashed'? Since this code was 
committed it's annoyed me to no end that I used 'skipped' instead of 'skips', 
since it is the only element in the past tense.

>          for each in self.results:
>              # Build a dict of the status output of all of the tests, with
> the @@ -377,6 +378,10 @@ class Summary:
>              if so.Skip() in status:
>                  self.tests['skipped'].add(test)
> 
> +            # Find all tests with a status of crash
> +            if so.Crash() in status:
> +                self.tests['crashed'].add(test)
> +
>              # find fixes, regressions, and changes
>              for i in xrange(len(status) - 1):
>                  first = status[i]
> @@ -474,7 +479,7 @@ class Summary:
>                                  output_encoding="utf-8",
>                                  module_directory=".makotmp")
> 
> -        pages = ('changes', 'problems', 'skipped', 'fixes', 'regressions')
> +        pages = ('changes', 'problems', 'skipped', 'fixes',
> 'regressions','crashed')

You need a space after the comma between regressions and crashed
You will also need to wrap the line, since with the extra element will exceed 
79 characters.

> 
>          # Index.html is a bit of a special case since there is index, all,
> and # alltests, where the other pages all use the same name. ie,

With those nits addressed this patch is:
reviewed-by Dylan Baker <baker.dylan.c at gmail.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20131031/f08de31a/attachment.pgp>