[Piglit] [PATCH] xfb: Fix max_varyings/max_xfb_varyings mix-up.

Paul Berry stereotype441 at gmail.com
Tue Sep 3 13:18:18 PDT 2013


The transform feedback max-varyings test had a mix-up between
max_varyings (the number of varying vec4's supported by the
implementation) and max_xfb_varyings (the number of transform feedback
output vec4's supported by the implementation).

As a result, we would run the test as though both values were
max_xfb_varyings, but we would check the results as though both values
were max_varyings.  This would cause spurious failures on
implementations for which max_varyings is greater than
max_xfb_varyings.
---
 tests/spec/ext_transform_feedback/max-varyings.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/spec/ext_transform_feedback/max-varyings.c b/tests/spec/ext_transform_feedback/max-varyings.c
index 126a34c..c1e3784 100644
--- a/tests/spec/ext_transform_feedback/max-varyings.c
+++ b/tests/spec/ext_transform_feedback/max-varyings.c
@@ -260,10 +260,10 @@ piglit_display(void)
 	glClear(GL_COLOR_BUFFER_BIT);
 
 	for (row = 0; row < max_xfb_varyings; row++) {
-		pass = draw(vs, fs, row + 1, max_xfb_varyings) && pass;
+		pass = draw(vs, fs, row + 1, max_varyings) && pass;
 	}
 
-	for (row = 0; row < max_varyings; row++) {
+	for (row = 0; row < max_xfb_varyings; row++) {
 		for (col = 0; col < max_varyings - row; col++) {
 			GLboolean ok;
 			float green[3] = {0.0, 1.0, 0.0};
-- 
1.8.4



More information about the Piglit mailing list