[Piglit] [PATCH 1/2] texture-integer: fix issue with GL_RGB_INTEGER_EXT swizzle

[Marek Olšák]

Pushed, thanks.

Marek

On Wed, Sep 4, 2013 at 8:46 PM, Martin Andersson <g02maran at gmail.com> wrote:
> Hi Marek,
>
> If there are no objections, maybe you could commit these patches?
>
> //Martin
>
> On Wed, Aug 28, 2013 at 12:25 PM, Marek Olšák <maraeo at gmail.com> wrote:
>> For the series:
>>
>> Reviewed-by: Marek Olšák <marek.olsak at amd.com>
>>
>> Marek
>>
>> On Tue, Aug 13, 2013 at 11:24 PM, Martin Andersson <g02maran at gmail.com> wrote:
>>> The expected alpha was set to zero instead of the random alpha value.
>>> The test passed for all random alpha values greater than zero, because
>>> for those values the resulting alpha was zero. Matching the, incorrect,
>>> expected alpha value of zero. The reason the resulting alpha was zero
>>> was because the computed bias became negative, that in turn caused the
>>> resulting alpha to become negative and then rounded to zero.
>>>
>>> The test failed when the random alpha value became zero because it was
>>> expecting the, incorrect, alpha value of zero but got the correct value
>>> of one.
>>> ---
>>>  tests/spec/gl-3.0/texture-integer.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tests/spec/gl-3.0/texture-integer.c b/tests/spec/gl-3.0/texture-integer.c
>>> index f2a5692..ff2bef4 100644
>>> --- a/tests/spec/gl-3.0/texture-integer.c
>>> +++ b/tests/spec/gl-3.0/texture-integer.c
>>> @@ -287,7 +287,7 @@ test_format(const struct format_info *info)
>>>                 /* nothing */
>>>                 break;
>>>         case GL_RGB_INTEGER_EXT:
>>> -               expected[3] = 0.0;
>>> +               value[3] = 0.0;
>>>                 break;
>>>         case GL_ALPHA_INTEGER_EXT:
>>>                 expected[0] = expected[1] = expected[2] = 0.0;
>>> --
>>> 1.8.3.4
>>>
>>> _______________________________________________
>>> Piglit mailing list
>>> Piglit at lists.freedesktop.org
>>> http://lists.freedesktop.org/mailman/listinfo/piglit