[Piglit] [PATCH] cl: fixed test create-context to test what it was supposed to test

Tom Stellard tom at stellard.net
Fri Sep 6 15:05:13 PDT 2013


On Fri, Aug 23, 2013 at 09:50:16AM +0300, Ville Korhonen wrote:
> fixed function parameters to match description.
> 

I've pushed this patch, but I'm having trouble applying your v2
retain/release patch:
http://lists.freedesktop.org/archives/piglit/2013-September/007158.html

I think it was mangled by your mail client.  Can you re-generate the
patch using git-format-patch and attach it to an email or submit it via
git send-email.

Thanks,
Tom

> diff --git a/tests/cl/api/create-context.c b/tests/cl/api/create-context.c
> index 7858940..f4929f0 100644
> --- a/tests/cl/api/create-context.c
> +++ b/tests/cl/api/create-context.c
> @@ -251,10 +251,10 @@ piglit_cl_test(const int argc,
>  	test(context_properties, num_devices, NULL, NULL, NULL,
>  	     CL_INVALID_VALUE, &result,
>  	     "Trigger CL_INVALID_VALUE if devices is NULL");
> -	test(context_properties, num_devices, devices, NULL, &context_properties,
> +	test(context_properties, 0, devices, NULL, NULL,
>  	     CL_INVALID_VALUE, &result,
>  	     "Trigger CL_INVALID_VALUE if num_devices is equal to zero");
> -	test(context_properties, 0, devices, NULL, NULL,
> +	test(context_properties, num_devices, devices, NULL, &context_properties,
>  	     CL_INVALID_VALUE, &result,
>  	     "Trigger CL_INVALID_VALUE if pfn_notify is NULL but user_data
> is not NULL");
> 
> 
> 
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit


More information about the Piglit mailing list