[Piglit] [PATCH v2 1/3] piglit-summary-html.py: Replace .read().split('\n') with .readlines()

Chad Versace chad.versace at linux.intel.com
Tue Sep 10 15:30:29 PDT 2013


There is typo in comments to patch 3: "reutrns".

Other than that, this series is
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>

On 08/29/2013 01:56 PM, Dylan Baker wrote:
> This is equivalent but simpler.
>
> Signed-off-by: Dylan Baker <baker.dylan.c at gmail.com>
> ---
>   piglit-summary-html.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/piglit-summary-html.py b/piglit-summary-html.py
> index 39ae474..6fed689 100755
> --- a/piglit-summary-html.py
> +++ b/piglit-summary-html.py
> @@ -39,7 +39,7 @@ def parse_listfile(filename):
>       element at the end.
>       """
>       with open(filename, 'r') as file:
> -        return [path.expanduser(i) for i in file.read().rstrip().split('\n')]
> +        return [path.expanduser(i.rstrip('\n')) for i in file.readlines()]
>
>
>   def main():
>



More information about the Piglit mailing list