[Piglit] [PATCH 2/4] cmake, dma_buf: Require xcb-dri2 for dma_buf tests

Chad Versace chad.versace at linux.intel.com
Thu Sep 12 10:03:31 PDT 2013


On 09/11/2013 05:35 AM, Pohjolainen, Topi wrote:
> On Tue, Sep 10, 2013 at 11:07:52AM -0700, Chad Versace wrote:
>> xcb-dri2 is an optional build dependency for the dma_buf tests.  If
>> xcb-dri2 is present, then the tests use it to gain DRM authentication.
>> Otherwise, the tests must be ran as root.
>>
>> No one likes running tests as root, so require xcb-dri2 for these tests.
>>
>> Signed-off-by: Chad Versace <chad.versace at linux.intel.com>
>> ---
>>   CMakeLists.txt                                      |  7 +++++--
>>   tests/util/CMakeLists.txt                           | 17 +++--------------
>>   tests/util/piglit-framework-gl/piglit_drm_dma_buf.c |  6 ------
>>   3 files changed, 8 insertions(+), 22 deletions(-)


>> --- a/tests/util/CMakeLists.txt
>> +++ b/tests/util/CMakeLists.txt
>> @@ -62,10 +62,13 @@ if(${CMAKE_SYSTEM_NAME} MATCHES "Linux")
>>
>>   		list(APPEND UTIL_GL_LIBS
>>   			${LIBDRM_LDFLAGS}
>> +			${XCB_DRI2_LDFLAGS}
>> +
>
> Is this extra line intentional?

No. I've fixed it locally in v2.



More information about the Piglit mailing list