[Piglit] [PATCH] arb_texture_cube_map_array: scale texcoords

Chris Forbes chrisf at ijw.co.nz
Fri Sep 13 23:23:31 PDT 2013


I'll have patches up to fix it shortly.

Sorry for leaving it broken so long -- I hadn't observed hangs.

-- Chris

On Sat, Sep 14, 2013 at 2:54 PM, Paul Berry <stereotype441 at gmail.com> wrote:
> On 9 September 2013 11:29, Paul Berry <stereotype441 at gmail.com> wrote:
>>
>> On 8 September 2013 02:10, Chris Forbes <chrisf at ijw.co.nz> wrote:
>>>
>>> The magnitude of the vector formed by the first three texcoords
>>> should not affect the result.
>>>
>>> This turns out to be a significant edge case in the i965 driver,
>>> which normalizes the coords such that the largest component does not
>>> exceed [-1..1], but currently bogusly multiplies the fourth coord
>>> [the array index] as well.
>>>
>>> Signed-off-by: Chris Forbes <chrisf at ijw.co.nz>
>>
>>
>> Reviewed-by: Paul Berry <stereotype441 at gmail.com>
>
>
> Now that this patch has landed, piglit test
> spec/ARB_texture_cube_map_array/arb_texture_cube_map_array-cubemap now fails
> for me on i965/gen7 (and sometimes also GPU hangs).  Is this expected?  If
> so, do you have patches planned to fix the problem, or should one of us
> Intel folks have a look at it?


More information about the Piglit mailing list