[Piglit] [PATCH 2/2] satus: Make use of the status objects

Eric Anholt eric at anholt.net
Wed Sep 18 15:54:45 PDT 2013

Dylan Baker <baker.dylan.c at gmail.com> writes:

> This adds code in framework/summary.py and framework/core.py to make use
> of the status classes in status.py. This makes comparisons between
> statuses much simpler and cleaner
> Signed-off-by: Dylan Baker <baker.dylan.c at gmail.com>
> ---
>                  if 'fixes' in lists:
>                      # Find both fixes and regressions, and append them to the
>                      # proper lists
>                      for i in xrange(len(status) - 1):
> -                        if status[i] < status[i + 1] and status[i] != 0:
> +                        if status[i] == Pass() and status[i + 1] != Pass():
>                              self.tests['regressions'].append(test)

This fails to report a regression for warn -> fail or fail -> crash.
But be sure that you don't report a regression for fail -> skip.

This is tricky and really important to get right.

Also make sure to have some changes involving not-run tests when you
make sure that you get the same html before and after.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20130918/394ce8d1/attachment.pgp>

More information about the Piglit mailing list