[Piglit] [PATCH 2/2] gl-3.1: Move draw-buffers-errors test from 3.2 to 3.1

Ian Romanick idr at freedesktop.org
Fri Sep 20 08:35:32 PDT 2013


On 09/19/2013 06:13 PM, Chad Versace wrote:
> On 09/19/2013 01:58 PM, Ian Romanick wrote:
>> From: Ian Romanick <ian.d.romanick at intel.com>
>>
>> The exact same spec language appears in the 3.1 spec.  Currently no Mesa
>> driver supports OpenGL 3.2, but there are drivers that support 3.1.
>> This allows the test to run now on those drivers.
>>
>> NOTE: This test currently fails in Mesa.
>>
>> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
>> Cc: Nicholas Mack <nichmack at gmail.com>
>> Cc: Paul Berry <stereotype441 at gmail.com>
>> ---
>>   tests/all.tests                         |   2 +-
>>   tests/spec/gl-3.1/CMakeLists.gl.txt     |   1 +
>>   tests/spec/gl-3.1/draw-buffers-errors.c | 110
>> ++++++++++++++++++++++++++++++++
>>   tests/spec/gl-3.2/CMakeLists.gl.txt     |   1 -
>>   tests/spec/gl-3.2/draw-buffers-errors.c | 110
>> --------------------------------
>>   5 files changed, 112 insertions(+), 112 deletions(-)
>>   create mode 100644 tests/spec/gl-3.1/draw-buffers-errors.c
>>   delete mode 100644 tests/spec/gl-3.2/draw-buffers-errors.c
>>
> 
> 
>> +static const GLenum invalids[]={
>> +    GL_FRONT,
>> +    GL_BACK,
>> +    GL_LEFT,
>> +    GL_RIGHT,
>> +    GL_FRONT_AND_BACK
>> +};
> 
> While we're fixing formatting, the above assignment needs ``s/[]={/[] =
> {/``.

Dang it!  I got the other one. :)

> With or without that nit,
> Reviewed-by: Chad Versace <chad.versace at linux.intel.com>
> 



More information about the Piglit mailing list