[Piglit] [PATCH 1/3] tests/util: fix detection of strndup

Latvala, Petri petri.latvala at intel.com
Wed Sep 25 00:40:43 PDT 2013

On Tue, 2013-09-24 at 15:59 -0700, Ian Romanick wrote:
> On 09/21/2013 11:30 AM, Kenney Phillis wrote:
> > There is no guarantee that cmake will blindly pass all of the defines
> > to the preprocessor.
> So... why doesn't "#define HAVE_STRNDUP" end up in tests/util/config.h
> (like "#define HAVE_SETRLIMIT")?  I assumed (apparently incorrectly)
> that would just happen when I first added this.
> In other words, what did I do wrong? :)  I want to get it right next time.

--- a/tests/util/config.h.in
+++ b/tests/util/config.h.in
@@ -8,3 +8,4 @@
 #cmakedefine HAVE_SYS_TIME_H
 #cmakedefine HAVE_SYS_RESOURCE_H
 #cmakedefine HAVE_UNISTD_H
+#cmakedefine HAVE_STRNDUP

This should be better for fixing this.

Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

More information about the Piglit mailing list