[Piglit] [PATCH V9] KHR_debug: test ObjectLabel(), GetObjectLabel(), ObjectPtrLabel() and GetObjectPtrLabel()

Timothy Arceri t_arceri at yahoo.com.au
Wed Sep 25 14:49:28 PDT 2013

Hi Guys,

Is someone able to review and hopefully commit this test. I have implemented all previous feedback on this test but have not had any further feedback on v8 or v9 so far. I would really like to move on to working on some tests for another extension.


----- Original Message -----
From: Timothy Arceri <t_arceri at yahoo.com.au>
To: piglit at lists.freedesktop.org
Cc: Timothy Arceri <t_arceri at yahoo.com.au>
Sent: Tuesday, 24 September 2013 9:16 PM
Subject: [PATCH V9] KHR_debug: test ObjectLabel(), GetObjectLabel(),  ObjectPtrLabel() and GetObjectPtrLabel()

V9: replace array index magic numbers with enums

V8: make sure all each object is available in the OpenGL
implementation before doing get/set tests
fix copy and paste mistake with framebuffer/renderbuffer tests

V7: be defensive when testing max label, use fprintf for errors,
code tidy ups, and added get/set tests for each object type

V6: fix spelling of generated in multiple places

V5: Removed unneeded assignment that was also out of bounds

V4: Removed failure test that will never be true

V3: changed indentation to tabs, use test label constants
and remove unused variable

V2: fixed whitespaces, broke tests into subtests,
added missing build dir, and tidied up fail messages

Signed-off-by: Timothy Arceri <t_arceri at yahoo.com.au>
tests/all.tests                           |    5 +
tests/spec/CMakeLists.txt                 |    1 +
tests/spec/khr_debug/CMakeLists.gl.txt    |   14 +
tests/spec/khr_debug/CMakeLists.txt       |    1 +
tests/spec/khr_debug/debug-object-label.c |  473 +++++++++++++++++++++++++++++
5 files changed, 494 insertions(+)
create mode 100644 tests/spec/khr_debug/CMakeLists.gl.txt
create mode 100644 tests/spec/khr_debug/CMakeLists.txt
create mode 100644 tests/spec/khr_debug/debug-object-label.c

More information about the Piglit mailing list