[Piglit] [PATCH 4/4] tests/xts.py: Add a tests file for the X Test suite.

[Ilia Mirkin]

On Fri, Apr 4, 2014 at 6:39 PM, Dylan Baker <baker.dylan.c at gmail.com> wrote:
> This adds support for running XTS from piglit.
>
> This patch was original written by Eric Anholt, but I've cleaned it up
> and reworked parts of it for upstreaming, and as a result I've attached
> my name as the author so ``git bisect'' and ``git blame'' will send
> angry mail my way instead of Eric's.
>
> Signed-off-by: Dylan Baker <baker.dylan.c at gmail.com>
> ---
>  framework/exectest.py      |   7 +-
>  framework/summary.py       |   3 +-
>  templates/test_result.mako |  27 +++++-
>  tests/xts.py               | 206 +++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 237 insertions(+), 6 deletions(-)
>  create mode 100644 tests/xts.py
>
> diff --git a/framework/exectest.py b/framework/exectest.py
> index c6c5067..3648c6d 100644
> --- a/framework/exectest.py
> +++ b/framework/exectest.py
> @@ -234,9 +234,10 @@ class Test(object):
>              if env:
>                  results['environment'] = env
>
> -            results['info'] = unicode("Returncode: {0}\n\nErrors:\n{1}\n\n"
> -                                      "Output:\n{2}").format(returncode,
> -                                                             err, out)
> +            results['info'] = \
> +                unicode("Returncode: {0}\n\nErrors:\n{1}\n\n"
> +                        "Output:\n{2}").format(returncode, err, out) + \
> +                            results.get('info', '')

Any reason not to stick that in as a {3}?

>              results['returncode'] = returncode
>              results['command'] = ' '.join(self.command)
>
> diff --git a/framework/summary.py b/framework/summary.py
> index 6d2a7bb..51923ad 100644
> --- a/framework/summary.py
> +++ b/framework/summary.py
> @@ -423,7 +423,8 @@ class Summary:
>                              info=value.get('info', 'None'),
>                              traceback=value.get('traceback', 'None'),
>                              command=value.get('command', 'None'),
> -                            dmesg=dmesg,
> +                            images=value.get('images', None),
> +                            dmesg=value.get('dmesg', None),

dmesg was messed up for a time, the computed dmesg value normalizes
runs that were made during the "bad" timeperiod.

>                              css=path.relpath(result_css, temp_path),
>                              index=path.relpath(index, temp_path)))
>