[Piglit] [PATCH] ES spec section 4.5.4 ("Default precision qualifier") : The fragment language has no default precision qualifier for floating point types. Hence for float, floating point vector and matrix variable declarations, either the declaration must include a precision qualifier or the default float precision must have been previously declared.

[Ken Phillis Jr]

The patch looks good, but I would suggest improving commit message... for
example...

Title (line 1): GLSL ES fix default precision qualifiers

The OpenGl ES specification for (whatever the version is being checked
against)  section 4.5.4 ("Default precision qualifier") : The fragment
language has no default precision qualifier for floating point types. Hence
for float, floating point vector and matrix variable declarations, either
the declaration must include a precision qualifier or the default float
precision must have been previously declared.

On Apr 8, 2014 7:42 AM, "Jin Zhou" <zhoujin10 at gmail.com> wrote:
>
> From: jin zhou <jin.zhou at amd.com>
>
> Signed-off-by: jin zhou <jin.zhou at amd.com>
> ---
>  .../arithmetic-operators/division-by-zero-01.frag  |    2 +-
>  .../qualifiers/fn-inout-array-allowed-cstyle.frag  |    2 +-
>  .../qualifiers/fn-out-array-allowed-cstyle.frag    |    2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git
a/tests/spec/glsl-es-1.00/compiler/arithmetic-operators/division-by-zero-01.frag
b/tests/spec/glsl-es-1.00/compiler/arithmetic-operators/division-by-zero-01.frag
> index 392e5c8..e3cc078 100644
> ---
a/tests/spec/glsl-es-1.00/compiler/arithmetic-operators/division-by-zero-01.frag
> +++
b/tests/spec/glsl-es-1.00/compiler/arithmetic-operators/division-by-zero-01.frag
> @@ -14,6 +14,6 @@ precision mediump float;
>
>  float
>  f() {
> -    float x = 1.0 / 0.0;
> +    highp float x = 1.0 / 0.0;
>      return x;
>  }
> diff --git
a/tests/spec/glsl-es-1.00/compiler/qualifiers/fn-inout-array-allowed-cstyle.frag
b/tests/spec/glsl-es-1.00/compiler/qualifiers/fn-inout-array-allowed-cstyle.frag
> index 0574a23..389322d 100644
> ---
a/tests/spec/glsl-es-1.00/compiler/qualifiers/fn-inout-array-allowed-cstyle.frag
> +++
b/tests/spec/glsl-es-1.00/compiler/qualifiers/fn-inout-array-allowed-cstyle.frag
> @@ -24,6 +24,6 @@ void f(inout float x[2])
>
>  void main()
>  {
> -  float[2] x;
> +  highp float[2] x;
>    f(x);
>  }
> diff --git
a/tests/spec/glsl-es-1.00/compiler/qualifiers/fn-out-array-allowed-cstyle.frag
b/tests/spec/glsl-es-1.00/compiler/qualifiers/fn-out-array-allowed-cstyle.frag
> index 241fb46..fa985c3 100644
> ---
a/tests/spec/glsl-es-1.00/compiler/qualifiers/fn-out-array-allowed-cstyle.frag
> +++
b/tests/spec/glsl-es-1.00/compiler/qualifiers/fn-out-array-allowed-cstyle.frag
> @@ -24,6 +24,6 @@ void f(out float x[2])
>
>  void main()
>  {
> -  float[2] x;
> +  highp float[2] x;
>    f(x);
>  }
> --
> 1.7.9
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140408/0acfd9a2/attachment.html>