[Piglit] [PATCH 9/9] framework/exectest.py: remove Test.split_test

Dylan Baker baker.dylan.c at gmail.com
Wed Apr 9 18:27:27 PDT 2014


This attribute was used exclusively by
PiglitTest.check_for_skip_scenario(), so just making it a local variable
of that function makes far more sense than making it a Test instance
attribute
---
 framework/exectest.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/framework/exectest.py b/framework/exectest.py
index 76f9be8..a759bcd 100644
--- a/framework/exectest.py
+++ b/framework/exectest.py
@@ -57,7 +57,6 @@ class Test(object):
         '''
         self.run_concurrent = run_concurrent
         self.command = command
-        self.split_command = os.path.split(self._command[0])[1]
         self.env = {}
 
         # This is a hook for doing some testing on execute right before
@@ -298,9 +297,10 @@ class PiglitTest(Test):
 
         """
         if PIGLIT_PLATFORM == 'gbm':
-            if 'glean' == self.split_command:
+            split_command = os.path.split(self._command[0])[1]
+            if 'glean' == split_command:
                 return True
-            if self.split_command.startswith('glx-'):
+            if split_command.startswith('glx-'):
                 return True
         return False
 
-- 
1.9.1



More information about the Piglit mailing list