[Piglit] More exectest cleanups and refactors

Ilia Mirkin imirkin at alum.mit.edu
Tue Apr 15 17:18:13 PDT 2014

With the exception of my comment on patch 5 (about patch 4) wrt
self.command being potentially None, this series is

Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

I threw in a few more comments, feel free to use or ignore them. For
the self.command thing being None... I saw in a later patch that you
got rid of that check entirely, so perhaps what you have is OK. While
I was reading the earlier patches that wasn't obvious though.


On Tue, Apr 15, 2014 at 7:12 PM, Dylan Baker <baker.dylan.c at gmail.com> wrote:
> This series offers additional cleanup, re-factors and optimizations to
> the Test class. This series puts a lot of work into Test.run() and
> Test.execute(), with a focus on reducing overall code, specifically
> function calls, combining if trees, and replacing slow with generators
> or comprehensions.
> Patches 1-2 lay groundwork for making these changes
> Patches 3-13 make incremental cleanups to Test.
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit

More information about the Piglit mailing list