[Piglit] EGL-related build errors starting with commit 6b71f217052

[Ilia Mirkin]

On Fri, Apr 18, 2014 at 2:02 PM, Ken Phillis Jr <kphillisjr at gmail.com> wrote:
> I think the best solution is to detect the support for the egl platform
> extension in the header, and this should be a trivial fix.

I think that's the best way to go too. However I have no idea how to
rewrite that function to not depend on that header. Perhaps it'd just
be sufficient to add like

#ifndef EGL_PLATFORM_X11_EXT
#define EGL_PLATFORM_X11_EXT 0xABCD
#endif

etc. But I'm not well-versed in all these details, and I don't really
know what this function does. If it's trivial, perhaps you can send a
proper fix?

  -ilia

>
> On Apr 18, 2014 10:13 AM, "Ilia Mirkin" <imirkin at alum.mit.edu> wrote:
>>
>> Hi Chad,
>>
>> I've recently started getting build errors on piglit, and have
>> narrowed it down to your commit 6b71f217052 ("util/egl: Add
>> piglit_egl_get_default_display()"). The build error I'm getting is
>>
>> tests/util/piglit-util-egl.c: In function
>> 'piglit_egl_get_default_display':
>> tests/util/piglit-util-egl.c:111:7: error: 'EGL_PLATFORM_X11_EXT'
>> undeclared (first use in this function)
>> tests/util/piglit-util-egl.c:111:7: note: each undeclared identifier
>> is reported only once for each function it appears in
>> tests/util/piglit-util-egl.c:116:7: error: 'EGL_PLATFORM_WAYLAND_EXT'
>> undeclared (first use in this function)
>> tests/util/piglit-util-egl.c:121:7: error: 'EGL_PLATFORM_GBM_MESA'
>> undeclared (first use in this function)
>> make[2]: ***
>> [target_api/no_api/tests/util/CMakeFiles/piglitutil.dir/piglit-util-egl.c.o]
>> Error 1
>>
>> And indeed, these defines do not exist in my system eglext.h (which
>> comes from Mesa 10.0.4). They do, however, appear in the mesa git one.
>>
>> I think it's a little annoying to force people to build against the
>> very latest EGL headers, but I guess it's not the worst thing in the
>> world either. However I was hoping there'd be a way to not force that,
>> for convenience. I'm not well-enough versed in (E)GL to know how to
>> deal with this though.
>>
>> Any ideas?
>>
>>   -ilia
>> _______________________________________________
>> Piglit mailing list
>> Piglit at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/piglit