[Piglit] [PATCH 1/2] egl/utils: Prepare egl_util_run to be called from piglit subtests.

[Chad Versace]

On Tue, Apr 22, 2014 at 06:29:46PM -0700, Sarah Sharp wrote:
> On Sat, Apr 19, 2014 at 12:20:26PM -0700, Chad Versace wrote:
> > On Fri, Apr 18, 2014 at 03:37:38PM -0700, Sarah Sharp wrote:

> > fail:
> >     if (state.egl_dpy) {
> >         eglMakeCurrent(state.egl_dpy, EGL_NO_SURFACE, EGL_NO_SURFACE, EGL_NO_CONTEXT);
> >         eglTerminate(state.egl_dpy);
> >     }
> >     if (state.win)
> >         XDestroyWindow(state.win);
> >     if (test->stop_on_failure)
> >     	piglit_report_result(test->result);
> >     if (test->result == PIGLIT_PASS)
> >     	return EXIT_SUCCESS;
> >     return EXIT_FAILURE;
> 
> Hmm, I tried changing the error cleanup to this code, and the tests do
> pass.  However, I see the odd behavior I was seeing before Rob helped me
> debug the code where the windows from the first and second subtest
> persist, until after the third subtest completes and
> piglit_report_result is called.
> 
> However, moving the eglTerminate call after the XDestroyWindow call
> makes the windows close as expected.  Any idea as to what's going on?

No idea. It sounds like an EGL or X11 bug to me. But maybe I'm
misunderstanding some quirk of the X protocol.