[Piglit] [PATCH] profile: Fix mixed concurrency runs

Ilia Mirkin imirkin at alum.mit.edu
Thu Apr 24 15:39:44 PDT 2014


On Thu, Apr 24, 2014 at 6:33 PM, Dylan Baker <baker.dylan.c at gmail.com> wrote:
> On Friday, April 25, 2014 00:24:47 Marek Olšák wrote:
>
>> I'm not sure I undertand this. I think the limitation for
>
>> non-concurrent tests is that they cannot be concurrently, because they
>
>> do front buffer rendering and other things. That doesn't mean all the
>
>> off-screen tests cannot be run with the non-concurrent tests
>
>> simultaneously.
>
>>
>
>> Marek
>
>
>
> So the bug was that with no -c or -1 option both pools were executed
> simultaneously, so a normal run ended up being concurrent with n+1 threads.

I think Marek's point is that this is fine, since it's fine to run a
test that is marked as "non-concurrent" concurrently with any number
of tests that are marked "concurrent". The only problem is multiple
"non-concurrent" tests running at once.

I don't know whether that's generically true, but if it is, then this
change should be reverted.

  -ilia


More information about the Piglit mailing list