[Piglit] [PATCH] textureGather: Avoid variable length arrays.

Jose Fonseca jfonseca at vmware.com
Mon Apr 28 14:06:45 PDT 2014


----- Original Message -----
> On Mon, Apr 28, 2014 at 10:12 AM,  <jfonseca at vmware.com> wrote:
> > From: José Fonseca <jfonseca at vmware.com>
> >
> > Not supported by MSVC.
> 
> Sorry, that was my bad.

No prob.

> Is there any way to get gcc to refuse the same
> (or at least similar) things to MSVC? Perhaps -std=c89 or something? I
> hate to cause build breaks for others, but it's hard to avoid when
> using different build tools. If some options for gcc get added to make
> it more like MSVC in terms of the language it accepts, these types of
> errors would hopefully become less frequent.

I did search, but couldn't find a good one.  The problem is that -std=c89 is too restrictive: there are several common things that are not part of c89 which msvc supports (e.g., anonymous structures, // coments, among other things.)

Anyway, I'm planning to upgrade to MSVC 2013 when building piglit, which supposedly has more c99 support.  And unlike Mesa tree, the MSVC used to build piglit is less of an issue. So this sort of issues will hopefully disappear.

Jose


More information about the Piglit mailing list