[Piglit] [PATCH 6/9] util: Fix SENTINEL.

jfonseca at vmware.com jfonseca at vmware.com
Tue Apr 29 10:57:51 PDT 2014


From: José Fonseca <jfonseca at vmware.com>

It should have been SENTINEL and not -SENTINEL in piglit_test_float,
as that what's checked below.

Also take in consideration that in general `(GLfoo)SENTINEL != SENTINEL`,
specially for GLfloat.
---
 tests/util/minmax-test.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/util/minmax-test.c b/tests/util/minmax-test.c
index bb1ab2d..dddd402 100644
--- a/tests/util/minmax-test.c
+++ b/tests/util/minmax-test.c
@@ -114,7 +114,7 @@ piglit_test_int(GLenum token, GLint limit, bool max)
 
 	piglit_report_int(name, limit, val,
 			  pass &&
-			  val != SENTINEL &&
+			  val != (GLint)SENTINEL &&
 			  ((max && val <= limit) ||
 			   (!max && val >= limit)));
 }
@@ -258,7 +258,7 @@ static void
 piglit_test_float(GLenum token, GLfloat limit, bool max)
 {
 	const char *name = piglit_get_gl_enum_name(token);
-	GLfloat val = -SENTINEL;
+	GLfloat val = SENTINEL;
 	bool pass;
 
 	glGetFloatv(token, &val);
@@ -267,7 +267,7 @@ piglit_test_float(GLenum token, GLfloat limit, bool max)
 
 	piglit_report_float(name, limit, val,
 			    pass &&
-			    val != SENTINEL &&
+			    val != (GLfloat)SENTINEL &&
 			    ((max && val <= limit) ||
 			     (!max && val >= limit)));
 }
-- 
1.9.1



More information about the Piglit mailing list