[Piglit] [PATCH 0/3] Update piglit install locations

[Jose Fonseca]

I was concerned this series will create problems with the "package" target.  The expectation is that the tarball produced by the "package" target will have precisely the necessary layout to run the piglit testsuite in a different machine (without needing the source tree.)


But I couldn't even get that far when I tried it here:

  $ git remote add jljusten  git://people.freedesktop.org/~jljusten/piglit
  $ git checkout piglit-cmd
  $ cmake -H. -Bbuild/piglit-cmd -DCMAKE_INSTALL_PREFIX=publish/piglit-cmd -G Ninja
  $ ninja -C build/piglit-cmd
  $ ninja -C build/piglit-cmd install
  [...]
  CMake Error at cmake_install.cmake:73 (FILE):
    file INSTALL cannot find "/home/jfonseca/work/vmware/tests/piglit/piglit".

  ninja: build stopped: subcommand failed.
  $ ninja -C build/piglit-cmd package
  ninja: Entering directory `build/piglit-cmd'
  [1/1] Run CPack packaging tool...
  FAILED: cd /home/jfonseca/work/vmware/tests/piglit/build/piglit-cmd && /usr/bin/cpack --config ./CPackConfig.cmake
  CPack: Create package using TBZ2
  CPack: Install projects
  CPack: - Install project: piglit
  CMake Error at /home/jfonseca/work/vmware/tests/piglit/build/piglit-cmd/cmake_install.cmake:73 (FILE):
  file INSTALL cannot find "/home/jfonseca/work/vmware/tests/piglit/piglit".


  CPack Error: Error when generating package: piglit
  ninja: build stopped: subcommand failed.


I suspect that the problem is that your Patch 3/3 is not safe for out-of-source builds.


Jose


----- Original Message -----
> Move piglit binaries and libraries out of the system paths
> 
> Add a piglit wrapper command to easily run piglit commands
> in the new install location
> 
> git://people.freedesktop.org/~jljusten/piglit piglit-cmd
> 
> Jordan Justen (3):
>   cmake: Install under separate piglit directory
>   cmake: Add version suffix for install paths
>   piglit: Add piglit command
> 
>  CMakeLists.txt          | 43 ++++++++++++++++++----
>  cmake/piglit_util.cmake |  4 +--
>  piglit.in               | 42 ++++++++++++++++++++++
>  piglit_cmd.py           | 96
>  +++++++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 177 insertions(+), 8 deletions(-)
>  create mode 100755 piglit.in
>  create mode 100755 piglit_cmd.py
> 
> --
> 1.9.2
> 
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> https://urldefense.proofpoint.com/v1/url?u=http://lists.freedesktop.org/mailman/listinfo/piglit&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=NMr9uy2iTjWVixC0wOcYCWEIYhfo80qKwRgdodpoDzA%3D%0A&m=sEMoRk5w037K%2FLcAKRlZNCrf5qrvHANx7DhcyXuMYxs%3D%0A&s=946b712461aa3e093ab66ea0402da7d9203cfe3d3f4f2ef8dd91f61462f5adfa
>