[Piglit] [PATCH 3/3] piglit: Add piglit command

Jordan Justen jljusten at gmail.com
Wed Apr 30 15:21:37 PDT 2014

On Wed, Apr 30, 2014 at 1:58 PM, Dylan Baker <baker.dylan.c at gmail.com> wrote:
> On Wednesday, April 30, 2014 13:42:09 Jordan Justen wrote:
>> Anyway, piglit_cmd.py is the source that controls the piglit command,
>> so it can evolve to present something different.
>> This patch seems like a reasonable step which would allow you to then
>> re-implement the unified interface as you see fit.
> It's not the interface I have a problem with, it's the implementation.
> This isn't what we want at all. There is zero code here I would want to
> use, and it creates a situation where the user interface will change,
> and we're left with unhappy users.

So, you are fine with the interface, but it is going to have to change?

And, our users (??) will be unhappy if we change the interface, but
you want to do something similar, and they'll be okay with that

And, you have no feedback other than throw it all out and create a
single argparsed based thing with a similar interface?

That about sum it up? :)

In terms of interface changes, I think 'piglit-run.py [args]' to
'piglit run [args]' is a fairly small adjustment.

I've really never thought piglit's command interface was particularly
bad (or good :), which is why I'm just looking to do the minimal
translation here. I do think it is pretty bad the way we install
piglit binaries and libraries, so I was just trying to fix that.


More information about the Piglit mailing list