[Piglit] [PATCH 1/2] util: don't minify height for 1D textures in piglit_depth_texture()

Ian Romanick idr at freedesktop.org
Mon Aug 4 20:38:01 PDT 2014


Series is

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

On 08/01/2014 09:25 AM, Brian Paul wrote:
> This was never hit since no callers create 1D mipmapped depth textures.
> But fix it anyway.
> ---
>  tests/util/piglit-util-gl.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c
> index bbea519..caeb564 100644
> --- a/tests/util/piglit-util-gl.c
> +++ b/tests/util/piglit-util-gl.c
> @@ -2369,7 +2369,9 @@ piglit_depth_texture(GLenum target, GLenum internalformat, int w, int h, int d,
>  
>  		if (w > 1)
>  			w >>= 1;
> -		if (h > 1)
> +		if (target != GL_TEXTURE_1D &&
> +		    target != GL_TEXTURE_1D_ARRAY &&
> +		    h > 1)
>  			h >>= 1;
>  	}
>  	free(data);
> 



More information about the Piglit mailing list