[Piglit] [PATCH] glsl-1.50-geometry-tri-strip-ordering-with-prim-restart: Remove dead code.

Brian Paul brianp at vmware.com
Thu Aug 7 05:23:46 PDT 2014


On 08/06/2014 07:23 PM, Vinson Lee wrote:
> tests is a static array.
>
> Fixes Coverity "Array compared against 0" defect.
>
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>   .../glsl-1.50/execution/geometry/tri-strip-ordering-with-prim-restart.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/tests/spec/glsl-1.50/execution/geometry/tri-strip-ordering-with-prim-restart.c b/tests/spec/glsl-1.50/execution/geometry/tri-strip-ordering-with-prim-restart.c
> index 025bfca..a1403d3 100644
> --- a/tests/spec/glsl-1.50/execution/geometry/tri-strip-ordering-with-prim-restart.c
> +++ b/tests/spec/glsl-1.50/execution/geometry/tri-strip-ordering-with-prim-restart.c
> @@ -193,8 +193,6 @@ piglit_init(int argc, char **argv)
>   			break;
>   		}
>   	}
> -	if (tests == NULL)
> -		print_usage_and_exit(argv[0]);
>   	if (strcmp(argv[2], "ffs") == 0)
>   		prim_restart_index = 0xff;
>   	else if (strcmp(argv[2], "other") == 0)
>

I think the correct fix is to replace 'tests' with 'test'.

-Brian



More information about the Piglit mailing list