[Piglit] Test Cleanups v2

Dylan Baker baker.dylan.c at gmail.com
Mon Aug 11 14:25:34 PDT 2014


On Monday, July 28, 2014 03:35:09 PM Dylan Baker wrote:
> This series implements improvements for piglit's test handling, mainly
> in the python layer. Generally these are just cleanups, additions of
> docstrings, formatting changes, renaming long functions, and removing
> deprecated code.
> 
> The big change behavioraly in this series is that that it moves the
> waffle platform default selection up the python layer instead of
> implicitly selecting it in the C layer. This allows means that the
> python code always *knows* what the platform being selected is and can
> skip tests accordingly. skipping tests in the python layer is much
> faster than skipping them in the C layer, because it bypasses
> initialization costs. It takes ~0.0001 seconds to skip a test in the
> python layer, where it takes ~0.1 seconds to skip in the C layer.
> 
> Patches 1-9 are small cleanups
> Patches 10-15 Implement the changes described above,
> Patches 16-17 do some refactoring to allow more code shareing
> Patch 18 uses ABC for the Test class, which is a powerful tool for
> 		 abstract base classes


After some consideration I have pushed this series without patches 16 and 17, while 
they do allow more code sharing and reduce the number of duplicate strings that need 
to be stored, teh added complexity to accomidate glean seemed not worth it, 
especially with the goal on the horizon of replacing glean.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140811/b6620d00/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140811/b6620d00/attachment.sig>


More information about the Piglit mailing list