[Piglit] [PATCH] arb_gpu_shader_fp64: add implicit conversion test

Chris Forbes chrisf at ijw.co.nz
Tue Aug 12 04:28:50 PDT 2014


On Tue, Aug 12, 2014 at 11:13 PM, Tapani Pälli <tapani.palli at intel.com> wrote:

> +double _double = 0.0lf;
> +dvec2 _dvec2 = dvec2(0.0f);
> +dvec3 _dvec3 = dvec3(0.0f);
> +dvec4 _dvec4 = dvec4(0.0f);

These don't need initializers; You only ever write them.

> +
> +mat2 _mat2;
> +mat3 _mat3;
> +mat4 _mat4;
> +mat2x3 _mat2x3;
> +mat2x4 _mat2x4;
> +mat3x2 _mat3x2;
> +mat3x4 _mat3x4;
> +mat4x2 _mat4x2;
> +mat4x3 _mat4x3;

These probably should have initializers, since you read them. Not a
huge deal though.


With the two suggestions above,

Reviewed-by: Chris Forbes <chrisf at ijw.co.nz>


More information about the Piglit mailing list