[Piglit] [PATCH] programs/run.py add file sync command line option
Dylan Baker
baker.dylan.c at gmail.com
Wed Aug 13 15:47:58 PDT 2014
[snip]
>
> Also using os.fsync will bypass any data that's still buffered and not
> sent out to the underlying API. You probably want a self.file.flush()
> in there.
>
> I'm also surprised this works at all. os.fsync should be expecting an
> int, so you'd have to use self.file.fileno(). Perhaps there's some
> magic that takes care of it somewhere (e.g. a __int__ override or
> something)
>
The documentation (https://docs.python.org/2/library/os.html#os.fsync)
specifically says that, so yes, this should be changed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140813/01900d41/attachment.sig>
More information about the Piglit
mailing list