[Piglit] [PATCH] programs/run.py add file sync command line option

Atwood, Matthew S matthew.s.atwood at intel.com
Thu Aug 14 15:28:35 PDT 2014


Im solid, patch version 3 uploaded

-----Original Message-----
From: Dylan Baker [mailto:baker.dylan.c at gmail.com] 
Sent: Thursday, August 14, 2014 1:38 PM
To: Atwood, Matthew S
Cc: piglit at lists.freedesktop.org
Subject: Re: [Piglit] [PATCH] programs/run.py add file sync command line option

On Thursday, August 14, 2014 04:55:04 PM Atwood, Matthew S wrote:

It shouldn't be a big deal, fsync() only blocks while writing to disk, if there's nothing to write, it wont block.

As to why write_dict_key is public, have a look at
JSONWriter.initialize_json() in the results.py module, I think that will make it clear

> open_dict is already calling the new file sync. I am hesitant to sync 
> write_dict_key for fear of unnecessary blocking calls. I am also 
> confused as to why that is a public api call, seems like it should 
> only be called by write_dict_item.
> 
[snip]


More information about the Piglit mailing list