[Piglit] Default window sizes and NPOT

Ilia Mirkin imirkin at alum.mit.edu
Fri Aug 15 07:52:23 PDT 2014


Brian,

You recently went on a campaign against setting .window_width/height
in piglit tests, in order to fix issues on Windows I guess? I noticed
that a bunch of failures on a NV17 card (GeForce4 MX 440) are due to
the fact that the window sizes are now 160x160 (NPOT) and the tests
use that in order to size their textures.

What is the proper way to resolve this? Temporarily I've changed the
default window width/height to 128, but that's not going to work more
generally for the same reason you increased it to 160x160. Should I
just do so on tests I identify as runnable on nouveau_vieux and that
also have this issue? Perhaps increase to 256x256? Something else?

You can find such tests with

git grep -C2 piglit_width tests/fbo | grep glTexImage

Not all of them run on nouveau_vieux, but some do.

Thanks for any advice,

  -ilia


More information about the Piglit mailing list