[Piglit] [PATCH] nv_conditional_render: reinstate width/height for mipmap generation

[Ilia Mirkin]

On Sun, Aug 17, 2014 at 6:02 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 17/08/14 19:03, Ilia Mirkin wrote:
>> The test relies on level 1 being used from the texture when rendering to
>> the window.
>>
> AFAICS Brian's recent "set minimum windows dimentions to AxB" was inspired by
> a Windows feature - if a window has a titlebar (and/or assositated buttons)
> it's minimum size cannot be less than X.

Right. This will make the test not work on windows. On the bright
side, it will make it test the thing that it is testing. As it is, you
can get rid of the glGenerateMipmaps call and the test will still
pass.

A cleverer individual could fix the test so that it both works on
windows and doesn't force a window width, but that is not me :)

>
> On the positive side, the windows waffle WGL creates do not have such
> restrictions :) Well they lack any input handling but that is an orthogonal
> issue :P
>
> -Emil
>
>> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
>> ---
>>  tests/spec/nv_conditional_render/generatemipmap.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/tests/spec/nv_conditional_render/generatemipmap.c b/tests/spec/nv_conditional_render/generatemipmap.c
>> index 37585d5..96a39bb 100644
>> --- a/tests/spec/nv_conditional_render/generatemipmap.c
>> +++ b/tests/spec/nv_conditional_render/generatemipmap.c
>> @@ -37,6 +37,8 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
>>
>>       config.supports_gl_compat_version = 10;
>>       config.window_visual = PIGLIT_GL_VISUAL_DOUBLE | PIGLIT_GL_VISUAL_RGBA;
>> +     config.window_width = 32;
>> +     config.window_height = 32;
>>
>>  PIGLIT_GL_TEST_CONFIG_END
>>
>>
>