[Piglit] Support for waffle WGL and related cleanups

Emil Velikov emil.l.velikov at gmail.com
Mon Aug 18 05:55:48 PDT 2014


On 13/08/14 14:08, Brian Paul wrote:
> On 08/12/2014 11:18 AM, Emil Velikov wrote:
>> Hello list,
>>
>> The series adds a piglit_wgl_framework based on my "Add WGL support
>> to waffle" GSoC this summer. A sizeable chunk of the waffle code is not
>> yet upstream, although I would expect that to change soon :P
>>
>> All but patches 04, 10 and 11 should be safe to land even without waffle
>> in place.
>>
>> NOTE: I have broken the waffle API in a non-backwards compatible way
>> and will update the above three to handle new and old waffle as soon
>> as waffle WGL lands upstream and the version is bumped.
>>
>> FWIW, with this series and the latest one of waffle I can reliably
>> lockup my nvidia GPU while running piglit on Windows 7 :)
>>
>> This series can be found in branch 'waffle-WGL' at
>> https://urldefense.proofpoint.com/v1/url?u=https://github.com/evelikov/piglit&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=lGQMzzTgII0I7jefp2FHq7WtZ%2BTLs8wadB%2BiIj9xpBY%3D%0A&m=CddOnmDlz5aH1zjrZeU33ysmfSWuyPviUBiN3J6nLrU%3D%0A&s=8d24d26b1abc98392e8f3942aed87dc09e2043ffafe61d61303ff9777575f7c4
>>
>>
>> while the latest waffle wgl (+fixes) 'yet-another-round-of-msvc-fixes'
>> at
>> https://urldefense.proofpoint.com/v1/url?u=https://github.com/evelikov/waffle&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=lGQMzzTgII0I7jefp2FHq7WtZ%2BTLs8wadB%2BiIj9xpBY%3D%0A&m=CddOnmDlz5aH1zjrZeU33ysmfSWuyPviUBiN3J6nLrU%3D%0A&s=d067ffd67d63004d28430effd2a65c87304ffae4366a3f4b6bf587c45e422605
>>
>>
>> Question, comments and reviews are greatly appreciated.
> 
> The series looks OK to me, AFAICT.  You might want to wait for Chad's review
> if you have any doubts though.
> 
> See my other replies for a few minor nits.
> 
> Reviewed-by: Brian Paul <brianp at vmware.com>
> 
Thanks for the review and comments Brian. Seems like I need to get a better
spell-checker :\

I've went ahead all but the waffle WGL patches. The latter of which I'll
postpone until all of waffle is in place.

-Emil





More information about the Piglit mailing list