[Piglit] [PATCH 05/12] cmake: cleanup PIGLIT_USE_WAFFLE builds

[Emil Velikov]

On 18/08/14 15:22, Jose Fonseca wrote:
> On 12/08/14 18:18, Emil Velikov wrote:
> [...]
>>   - Use WAFFLE_LIBRARIES over WAFFLE_LDFLAGS for linking purposes.
> [...]
> 
> Emil,
> 
> This particular change is causing the build to fail when libwaffle-1.so is not
> on a standard library directory (ie., outside /usr/lib or /usr/local/lib). 
> This happened to me as my build machines don't install waffle on system
> directories.
> 
> I'm not sure what was the driver for replacing WAFFLE_LIBRARIES with
> WAFFLE_LDFLAGS, but I believe we should undo it.
> 
The driver behind the change is (if I understand the cmake manual) that one
should not use the *_LDFLAGS variables, but only INCLUDE_DIRS and LIBRARIES.

I suspect that there is a bug with waffle-1.pc can you attach/inline it ?

Whereas for a quick fix I would recommend adding back WAFFLE_LDFLAGS in
set(UTIL_GL_LIBS....


Emil

> Jose
>