[Piglit] [PATCH] cmake: WAFFLE_LIBRARIES -> WAFFLE_LDFLAGS

Jose Fonseca jfonseca at vmware.com
Tue Aug 19 07:26:35 PDT 2014


On 18/08/14 17:54, Emil Velikov wrote:
> On 18/08/14 16:49, jfonseca at vmware.com wrote:
>> From: José Fonseca <jfonseca at vmware.com>
>>
> Had a chat with the guys at #cmake and it seems like I've got it wrong - one
> ought to use *LDFLAGS, esp. if the library is installed outside of /usr/lib.

Thanks for checking this out Emil.

> Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>

I'm sorry, I only saw your reply after pushing, so it didn't get your 
Reviewed-by.

Jose

>
>> Otherwise the build fails when libwaffle-1.so is not on a standard
>> library directory (ie., outside /usr/lib or /usr/local/lib).
>> ---
>>   tests/util/CMakeLists.txt | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/util/CMakeLists.txt b/tests/util/CMakeLists.txt
>> index b71fc52..d8a72df 100644
>> --- a/tests/util/CMakeLists.txt
>> +++ b/tests/util/CMakeLists.txt
>> @@ -77,7 +77,7 @@ if(PIGLIT_USE_WAFFLE)
>>   	endif()
>>
>>   	list(APPEND UTIL_GL_LIBS
>> -		${WAFFLE_LIBRARIES}
>> +		${WAFFLE_LDFLAGS}
>>   	)
>>   else()
>>   	list(APPEND UTIL_GL_SOURCES
>>
>



More information about the Piglit mailing list