[Piglit] [PATCH] arb_texture_view: Fix bogus probe rects

Ilia Mirkin imirkin at alum.mit.edu
Fri Aug 22 20:09:45 PDT 2014


Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

Well, it passed with gallium, I guess glReadPixels() clamps. I should have
looked at other probe usages... I assumed it was in -1..1 space, but
clearly not.


On Fri, Aug 22, 2014 at 11:09 PM, Chris Forbes <chrisf at ijw.co.nz> wrote:

> Signed-off-by: Chris Forbes <chrisf at ijw.co.nz>
> ---
>  tests/spec/arb_texture_view/sampling-2d-array-as-cubemap-array.c | 2 +-
>  tests/spec/arb_texture_view/sampling-2d-array-as-cubemap.c       | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git
> a/tests/spec/arb_texture_view/sampling-2d-array-as-cubemap-array.c
> b/tests/spec/arb_texture_view/sampling-2d-array-as-cubemap-array.c
> index e4857c3..2415652 100644
> --- a/tests/spec/arb_texture_view/sampling-2d-array-as-cubemap-array.c
> +++ b/tests/spec/arb_texture_view/sampling-2d-array-as-cubemap-array.c
> @@ -52,7 +52,7 @@ piglit_display(void)
>
>         piglit_draw_rect(-1, -1, 2, 2);
>
> -       pass = piglit_probe_rect_rgba(-1, -1, 2, 2, green);
> +       pass = piglit_probe_rect_rgba(0, 0, piglit_width, piglit_height,
> green);
>
>         piglit_present_results();
>
> diff --git a/tests/spec/arb_texture_view/sampling-2d-array-as-cubemap.c
> b/tests/spec/arb_texture_view/sampling-2d-array-as-cubemap.c
> index 2366d0c..987c797 100644
> --- a/tests/spec/arb_texture_view/sampling-2d-array-as-cubemap.c
> +++ b/tests/spec/arb_texture_view/sampling-2d-array-as-cubemap.c
> @@ -52,7 +52,7 @@ piglit_display(void)
>
>         piglit_draw_rect(-1, -1, 2, 2);
>
> -       pass = piglit_probe_rect_rgba(-1, -1, 2, 2, green);
> +       pass = piglit_probe_rect_rgba(0, 0, piglit_width, piglit_height,
> green);
>
>         piglit_present_results();
>
> --
> 2.0.4
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140822/ea659ad1/attachment.html>


More information about the Piglit mailing list