[Piglit] [PATCH] arb_explicit_uniform_location: test explicit location for a sampler

Tapani tapani.palli at intel.com
Tue Aug 26 01:35:53 PDT 2014


On 08/26/2014 12:32 AM, Chris Forbes wrote:
> Either with or without the reduction in version requirements [to ~1.30
> + ARB_explicit_attrib_location + ARB_explicit_uniform_location] that
> we discussed in IRC;

Thanks for review, I've pushed it in as is for now. I can push later a 
change for all these tests to lower the requirements.

> Reviewed-by: Chris Forbes <chrisf at ijw.co.nz>
>
> On Fri, Aug 22, 2014 at 5:04 PM, Tapani Pälli <tapani.palli at intel.com> wrote:
>> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82921
>> ---
>>   .../linker/set-location-to-sampler.shader_test     | 22 ++++++++++++++++++++++
>>   1 file changed, 22 insertions(+)
>>   create mode 100644 tests/spec/arb_explicit_uniform_location/linker/set-location-to-sampler.shader_test
>>
>> diff --git a/tests/spec/arb_explicit_uniform_location/linker/set-location-to-sampler.shader_test b/tests/spec/arb_explicit_uniform_location/linker/set-location-to-sampler.shader_test
>> new file mode 100644
>> index 0000000..c2716e3
>> --- /dev/null
>> +++ b/tests/spec/arb_explicit_uniform_location/linker/set-location-to-sampler.shader_test
>> @@ -0,0 +1,22 @@
>> +#
>> +# Tests that an opaque type (sampler) gets a location succesfully
>> +#
>> +[require]
>> +GL >= 3.3
>> +GLSL >= 3.30
>> +GL_ARB_explicit_uniform_location
>> +
>> +[vertex shader passthrough]
>> +
>> +[fragment shader]
>> +#version 330
>> +#extension GL_ARB_explicit_uniform_location: require
>> +layout(location = 0) uniform sampler2D tex;
>> +out vec4 color;
>> +void main()
>> +{
>> +       color = texture(tex, vec2(0.0, 0.0));
>> +}
>> +
>> +[test]
>> +link success
>> --
>> 1.9.3
>>



More information about the Piglit mailing list