[Piglit] Are Piglit tests for deleted GL_EXT_separate_shader_objects obsolete

Ian Romanick idr at freedesktop.org
Tue Aug 26 10:17:40 PDT 2014


We don't usually remove tests from piglit even when functionality is
removed from Mesa.  There are plenty of other tests in piglit that are
skipped on different drivers.

There's nothing stopping you from submitting a patch... ;)

On 08/26/2014 02:00 AM, Popov, Pavel E wrote:
> Hi Ian, All,
> 
>  
> 
> Desktop OpenGL extension “GL_EXT_separate_shader_objects” was completely
> removed from Mesa
> 
> http://cgit.freedesktop.org/mesa/mesa/commit/?id=fb615feafb848bbccbdb751f552263bd32a37d82
> 
>  
> 
> But all these Piglit tests were written to check this extension and now
> they are skipped:
> 
> tests/shaders/activeprogram-bad-program.c
> 
> tests/shaders/activeprogram-get.c
> 
> tests/shaders/createshaderprogram-attached-shaders.c
> 
> tests/shaders/createshaderprogram-bad-type.c
> 
> tests/shaders/sso-simple.c
> 
> tests/shaders/sso-uniforms-01.c
> 
> tests/shaders/sso-uniforms-02.c
> 
> tests/shaders/sso-user-varying-01.c
> 
> tests/shaders/sso-user-varying-02.c
> 
> tests/shaders/useshaderprogram-bad-program.c
> 
> tests/shaders/useshaderprogram-bad-type.c
> 
> tests/shaders/useshaderprogram-flushverts-1.c
> 
> tests/spec/arb_geometry_shader4/linker/no-vertex-shader-only-built-in-input-varyings-ext-separate-shader-objects.shader_test
> 
>  
> 
> Looks like these tests are obsolete. Should they be removed from Piglit?
> 
>  
> 
> Regards,
> 
> Pavel
> 



More information about the Piglit mailing list