[Piglit] [PATCH 1/2] tests/all.py: Fix name of arb_tessellation_shader test

[Ilia Mirkin]

On Thu, Aug 28, 2014 at 7:06 PM, Dylan Baker <baker.dylan.c at gmail.com> wrote:
> '/' is not allowed in the name of tests because it is the delimiter for
> group names. This test includes '/' which causes the HTML summary to
> render in odd ways.
>
> Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
> ---
>
> Hi Chris,
>
> This is a pretty easy problem to solve, I've added an assertion in the
> second patch to catch this bug.
>
> Hopefully this works for you?
>
> -Dylan
>
>  tests/all.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/all.py b/tests/all.py
> index 20ebec2..2adaf64 100644
> --- a/tests/all.py
> +++ b/tests/all.py
> @@ -1513,7 +1513,7 @@ add_concurrent_test(arb_tessellation_shader, 'arb_tessellation_shader-minmax')
>  add_concurrent_test(arb_tessellation_shader, 'arb_tessellation_shader-invalid-get-program-params')
>  add_concurrent_test(arb_tessellation_shader, 'arb_tessellation_shader-invalid-patch-vertices-range')
>  add_concurrent_test(arb_tessellation_shader, 'arb_tessellation_shader-invalid-primitive')
> -add_concurrent_test(arb_tessellation_shader, 'built-in-constants tests/spec/arb_tessellation_shader/minimum-maximums.txt')
> +profile.test_list['spec/ARB_tessellation_shader/built-in-constants'] = concurrent_test('built-in-constants tests/spec/arb_tessellation_shader/minimum-maximums.txt')

Isn't the way that every other place does it more like

arb_tessellation_shader['built-in-constants'] = concurrent_test(...)

If you want to convert everything over to doing
profile.test_list[...], that's best not done one-at-a-time...

>  add_concurrent_test(arb_tessellation_shader, 'arb_tessellation_shader-minmax')
>  import_glsl_parser_tests(arb_tessellation_shader,
>                           os.path.join(testsDir, 'spec',
> --
> 2.1.0
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit