[Piglit] [PATCH] framework: Use os.mkdirs instead of os.mkdir for summary subfolders

Ilia Mirkin imirkin at alum.mit.edu
Sat Aug 30 12:14:44 PDT 2014


[+dylan, who's quite familiar with all these little details]

Can you elaborate a little on the situation that's causing your
issues? Is http://cgit.freedesktop.org/piglit/commit/?id=3457f015314e57007b74918f79d8d02e4ada6ad7
going to make things even worse for you?

On Sat, Aug 30, 2014 at 2:49 PM, Jason Ekstrand <jason at jlekstrand.net> wrote:
> This way test names can contain "/" characters.  I to name tests after git
> branches and I tend to have git branches named wip/whatever.  This prevents
> piglit from crashing.
> ---
>  framework/summary.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/framework/summary.py b/framework/summary.py
> index 332aa40..1815dc7 100644
> --- a/framework/summary.py
> +++ b/framework/summary.py
> @@ -454,7 +454,7 @@ class Summary:
>
>          # Iterate across the tests creating the various test specific files
>          for each in self.results:
> -            os.mkdir(path.join(destination, each.name))
> +            os.makedirs(path.join(destination, each.name))
>
>              if each.time_elapsed is not None:
>                  time = datetime.timedelta(0, each.time_elapsed)
> --
> 2.1.0
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit


More information about the Piglit mailing list