[Piglit] [PATCH] framework: Use os.mkdirs instead of os.mkdir for summary subfolders

Dylan Baker baker.dylan.c at gmail.com
Sat Aug 30 15:23:36 PDT 2014


I'll need to think about it and read the code to be sure, I think that
using '/' in test run names may cause some strange behavior in the html
pages because of assumptions. There's also the windows '\\' issue to
think about.

But, either way you need to put makedirs in a try/except block
try:
	os.makedirs(...)
except OSError:
	pass


On Saturday, August 30, 2014 11:49:51 AM Jason Ekstrand wrote:
> This way test names can contain "/" characters.  I to name tests after git
> branches and I tend to have git branches named wip/whatever.  This prevents
> piglit from crashing.
> ---
>  framework/summary.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/framework/summary.py b/framework/summary.py
> index 332aa40..1815dc7 100644
> --- a/framework/summary.py
> +++ b/framework/summary.py
> @@ -454,7 +454,7 @@ class Summary:
>  
>          # Iterate across the tests creating the various test specific files
>          for each in self.results:
> -            os.mkdir(path.join(destination, each.name))
> +            os.makedirs(path.join(destination, each.name))
>  
>              if each.time_elapsed is not None:
>                  time = datetime.timedelta(0, each.time_elapsed)
> -- 
> 2.1.0
> 
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20140830/2a972440/attachment.sig>


More information about the Piglit mailing list