[Piglit] [PATCH v2] util/gl: link against OPENGL_gl_LIBRARY on waffle aware systems

Emil Velikov emil.l.velikov at gmail.com
Wed Dec 3 05:20:22 PST 2014


On 01/12/14 18:17, Chad Versace wrote:
> On 11/26/2014 01:11 AM, Emil Velikov wrote:
>> Similar to the earlier patch for waffle-less (glut) builds. The need
>> for this patch became apparent as we removed the libGL link dependency
>> in waffle.
>>
>> v2: Try to handle both gl and gles*.
>>
>> Cc: Mark Janes <mark.a.janes at intel.com>
>> Reported-by: Mark Janes <mark.a.janes at intel.com>
>> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
>> ---
>>  tests/util/CMakeLists.txt | 5 +++++
>>  1 file changed, 5 insertions(+)
> 
> Strangely, I can't reproduce the linking error on Fedora 20.
> 
To reproduce you need to have the GLX tests enabled plus one of the
following:
 - "New" or no Waffle installed systemwide.
 - Set LD_LIBRARY_PATH to the "new" waffle, as you build/install piglit.

> Anyway, this patch looks good to me.
> Reviewed-by: Chad Versace <chad.versace at linux.intel.com>
> 
> And pushed, because Mark just poked me to do it.
> 
Got sidetracked with other things, thanks :)

-Emil


More information about the Piglit mailing list