[Piglit] [RFC 01/12] gen_constant_array_size_tests.py: fix minor abc issues.

Dylan Baker baker.dylan.c at gmail.com
Mon Dec 8 17:11:22 PST 2014


- Make ParserTest actually a abc.ABCMeta (otherwise abc decorators do
  nothing).
- Add output_var as an abstract method for ParserTest (this was
  expected, it just wasn't part of the abc)

Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
---
 generated_tests/gen_constant_array_size_tests.py | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/generated_tests/gen_constant_array_size_tests.py b/generated_tests/gen_constant_array_size_tests.py
index c395b1a..fcbd05a 100644
--- a/generated_tests/gen_constant_array_size_tests.py
+++ b/generated_tests/gen_constant_array_size_tests.py
@@ -46,6 +46,7 @@ class ParserTest(object):
     abstract base class--derived types should override test_suffix(),
     output_var(), and other functions if necessary.
     """
+    __metaclass__ = abc.ABCMeta
 
     def __init__(self, signature, test_vectors):
         """Prepare to build a test for a single built-in.  signature
@@ -92,6 +93,10 @@ class ParserTest(object):
         shader test.
         """
 
+    @abc.abstractmethod
+    def output_var(self):
+        """Return the output variable for the test."""
+
     def make_condition(self, test_vector):
         """Generate a GLSL constant expression that should evaluate to
         true if the GLSL compiler's constant evaluation produces the
-- 
2.2.0



More information about the Piglit mailing list