[Piglit] [PATCH 2/3] Use alloca instead of variable length arrays

[Jan Vesely]

On Fri, 2014-12-12 at 12:58 -0800, Matt Turner wrote:
> I'm curious what the motivation for removing variably-sized arrays is,
> but if I accept that that's a good thing to do then the first patch
> makes sense, but I don't understand this one.
> 
> How is a variably-size array different from using alloca()?

variable size arrays are a c99 feature not supported by msvc (that's why
there is a warning). I don't know which parts actually do need to build
using msvc, but it seemed like a good idea to reduce warning output (and
improve consistency with code that needs to build using msvc).

In the first patch I used alloca+free, because it looked nicer than
doing size arithmetic. The other cases allocate byte arrays, and the
only difference is that alloca (_alloca) is supported by msvc.

I have another patch that changes msvc compatibility
warnings(declaration after statement, vla) into errors, not sure if
anyone would be interested in that.

jan

-- 
Jan Vesely <jan.vesely at rutgers.edu>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20141212/fb5a7cb8/attachment.sig>