[Piglit] [PATCH 0/3] Add a folder and some tests for SSA tests

Glenn Kennard glenn.kennard at gmail.com
Sun Dec 14 04:53:40 PST 2014


On Sat, 13 Dec 2014 22:26:00 +0100, Jason Ekstrand <jason at jlekstrand.net>  
wrote:

> This short little series adds a folder and 3 tests for problems that may
> arise if your compiler translates to/from SSA form incorrectly.  The  
> first
> two are just the classic "swap" and "lost copy" problems that you can  
> find
> in any out-of-SSA paper.  The third is a strange edge-case in into-SSA
> translation that Connor Abbot pointed out to me on IRC last night.
>
> I put these tests in their own folder because, while they are just  
> compiler
> tests, they are fairly specific to SSA form.  We probably want more SSA
> tests, but most of the other SSA bugs I've seen are already covered in a
> reasonably minimal way by control flow that happens all the time in  
> piglit.
>
> Jason Ekstrand (3):
>   ssa: Add a test for the classic "swap problem" in out-of-SSA
>     translation
>   ssa: Add a test for the classic "lost copy problem" in out-of-SSA
>     translation
>   ssa: Add a test for an edge case in into-SSA translation
>
>  tests/shaders/ssa/fs-if-def-else-break.shader_test | 30  
> ++++++++++++++++++++++
>  tests/shaders/ssa/fs-lost-copy-problem.shader_test | 23  
> +++++++++++++++++
>  tests/shaders/ssa/fs-swap-problem.shader_test      | 19 ++++++++++++++
>  3 files changed, 72 insertions(+)
>  create mode 100644 tests/shaders/ssa/fs-if-def-else-break.shader_test
>  create mode 100644 tests/shaders/ssa/fs-lost-copy-problem.shader_test
>  create mode 100644 tests/shaders/ssa/fs-swap-problem.shader_test
>


Test 3 triggers the same kind of bug in SB so its definitely a worthwhile  
test case.

Series is
Reviewed-By: Glenn Kennard <glenn.kennard at gmail.com>


More information about the Piglit mailing list