[Piglit] [PATCH] teximage-colors: Remove self assignment.

Brian Paul brianp at vmware.com
Sun Dec 14 09:15:17 PST 2014


On 12/13/2014 10:18 PM, Vinson Lee wrote:
> Fix self assignment defect reported by Coverity.
>
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>   tests/texturing/teximage-colors.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/tests/texturing/teximage-colors.c b/tests/texturing/teximage-colors.c
> index 001626d..a546697 100644
> --- a/tests/texturing/teximage-colors.c
> +++ b/tests/texturing/teximage-colors.c
> @@ -669,7 +669,6 @@ to_expected(GLenum test_format, GLenum test_type, void *up_raw, float *expected)
>   	case GL_LUMINANCE:
>   		expected[3] = 1.0f;
>   	case GL_LUMINANCE_ALPHA:
> -		expected[0] = expected[0];
>   		expected[1] = expected[0];
>   		expected[2] = expected[0];
>   		break;
>

For this and the v2 teximage-color patch:
Reviewed-by: Brian Paul <brianp at vmware.com>



More information about the Piglit mailing list