[Piglit] [PATCH 3/3] cmake, gles: Remove target from the lib list

[Jan Vesely]

On Sun, 2014-12-14 at 16:16 +0000, Emil Velikov wrote:
> On 12/12/14 19:33, Jan Vesely wrote:
> > Fixes Target links to itself cmake warnings
> > 
> > Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
> > ---
> > 
> Hmm those seems exist since day 1, yet the intent seems to be missing.
> 
> Currently the library tries to link against itself, which is why cmake
> is printing out the warnings.
> 
> Thanks for clearing this up :)
> 
> Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>

thanks, do you mind pushing it as well?
my account request bug is stuck

jan

> 
> > compile tested. no missing symbols or libraries reported for libpiglitutils_glesX.so
> > 
> >  tests/util/CMakeLists.gles1.txt | 1 -
> >  tests/util/CMakeLists.gles2.txt | 1 -
> >  tests/util/CMakeLists.gles3.txt | 1 -
> >  3 files changed, 3 deletions(-)
> > 
> > diff --git a/tests/util/CMakeLists.gles1.txt b/tests/util/CMakeLists.gles1.txt
> > index 4342cf2..cd9e90d 100644
> > --- a/tests/util/CMakeLists.gles1.txt
> > +++ b/tests/util/CMakeLists.gles1.txt
> > @@ -4,7 +4,6 @@ include_directories(
> >  
> >  link_libraries(
> >  	${UTIL_GL_LIBS}
> > -	piglitutil_${piglit_target_api}
> >  	)
> >  
> >  piglit_add_library(piglitutil_${piglit_target_api}
> > diff --git a/tests/util/CMakeLists.gles2.txt b/tests/util/CMakeLists.gles2.txt
> > index 4342cf2..cd9e90d 100644
> > --- a/tests/util/CMakeLists.gles2.txt
> > +++ b/tests/util/CMakeLists.gles2.txt
> > @@ -4,7 +4,6 @@ include_directories(
> >  
> >  link_libraries(
> >  	${UTIL_GL_LIBS}
> > -	piglitutil_${piglit_target_api}
> >  	)
> >  
> >  piglit_add_library(piglitutil_${piglit_target_api}
> > diff --git a/tests/util/CMakeLists.gles3.txt b/tests/util/CMakeLists.gles3.txt
> > index fec284a..a23c0c7 100644
> > --- a/tests/util/CMakeLists.gles3.txt
> > +++ b/tests/util/CMakeLists.gles3.txt
> > @@ -4,7 +4,6 @@ include_directories(
> >  
> >  link_libraries(
> >  	${UTIL_GL_LIBS}
> > -	piglitutil_${piglit_target_api}
> >  	)
> >  
> >  piglit_add_library(piglitutil_${piglit_target_api}
> > 
> 

-- 
Jan Vesely <jan.vesely at rutgers.edu>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20141216/7fbff45b/attachment-0001.sig>