[Piglit] [PATCH] arb_sample_shading-builtin-gl-num-samples: Use const reference.

Brian Paul brianp at vmware.com
Wed Dec 17 07:35:54 PST 2014


On 12/16/2014 11:07 PM, Vinson Lee wrote:
> Fix Coverity "big parameter passed by value" defect.
>
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>   tests/spec/arb_sample_shading/execution/builtin-gl-num-samples.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/spec/arb_sample_shading/execution/builtin-gl-num-samples.cpp b/tests/spec/arb_sample_shading/execution/builtin-gl-num-samples.cpp
> index 620c12e..08bbea9 100644
> --- a/tests/spec/arb_sample_shading/execution/builtin-gl-num-samples.cpp
> +++ b/tests/spec/arb_sample_shading/execution/builtin-gl-num-samples.cpp
> @@ -118,7 +118,7 @@ piglit_init(int argc, char **argv)
>   	}
>   }
>
> -bool test_builtin_num_samples(Fbo ms_fbo)
> +bool test_builtin_num_samples(const Fbo& ms_fbo)
>   {
>   	GLint samples;
>           GLfloat expected[4] = {0.0, 1.0, 0.0, 1.0};
>

For both arb_sample_shading patches,
Reviewed-by: Brian Paul <brianp at vmware.com>



More information about the Piglit mailing list