[Piglit] [PATCH] tests/all.py: use list for asmparsertest command line arguments

Dylan Baker baker.dylan.c at gmail.com
Wed Dec 17 09:51:39 PST 2014


LGTM,
Reviewed-by: Dylan Baker <dylanx.c.baker at intel.com>

On Wednesday, December 17, 2014 10:24:38 AM Brian Paul wrote:
> Instead of passing a string like "asmparsertest ARBfp1.0 path/to/mad.txt",
> now pass a list like ["asmparsertest", "ARBfp1.0", path/to/mad.txt].
> 
> This fixes the asmparsertest tests on Cygwin.  Before, all the tests
> were failing because the backslash characters in the path were getting
> removed.
> ---
>  tests/all.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/all.py b/tests/all.py
> index fe623b8..e518222 100644
> --- a/tests/all.py
> +++ b/tests/all.py
> @@ -3738,8 +3738,8 @@ add_plain_test(fast_color_clear, 'fcc-read-to-pbo-after-clear')
>  asmparsertest = {}
>  def add_asmparsertest(group, shader):
>      asmparsertest[group + '/' + shader] = PiglitGLTest(
> -        'asmparsertest ' + group + ' ' +
> -        os.path.join(testsDir, 'asmparsertest', 'shaders', group, shader),
> +        ['asmparsertest', group,
> +         os.path.join(testsDir, 'asmparsertest', 'shaders', group, shader)],
>          run_concurrent=True)
>  
>  add_asmparsertest('ARBfp1.0', 'abs-01.txt')
> -- 
> 1.9.1
> 
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20141217/62e05be7/attachment-0001.sig>


More information about the Piglit mailing list