[Piglit] [PATCH] framework: Fix 'module' object has no attribute 'XMLSyntaxError'.

Dylan Baker baker.dylan.c at gmail.com
Wed Dec 17 11:04:16 PST 2014


You're correct. I misread xml.SyntaxError as XMLSyntaxError on the
webpage. oops

On Wednesday, December 17, 2014 06:45:11 PM Jose Fonseca wrote:
> On 17/12/14 17:49, Dylan Baker wrote:
> > With one very minor nit,
> > Reviewed-by: Dylan Baker <dylanx.c.baker at intel.com>
> 
> Thanks for the review.
> 
> > On Wednesday, December 17, 2014 11:05:29 AM Jose Fonseca wrote:
> >> From: José Fonseca <jfonseca at vmware.com>
> >>
> >> etree.XMLSyntaxError is only available with lxml.  etree.ParseError is
> >> available everywhere.  For lxml, etree.XMLSyntaxError is a subclass of
> >> etree.ParseError.
> >
> > Actually, lxml.etree.ParseError is a subclass of
> > lxml.etree.XMLSyntaxError.
> 
> Really? Odd, `pydoc lxml.etree` shows otherwise:
> 
> $  pydoc lxml.etree
> [...]
> CLASSES
> [...]
>      exceptions.Exception(exceptions.BaseException)
>          Error
>              LxmlError
>                  C14NError
>                  DTDError
>                      DTDParseError
>                      DTDValidateError
>                  DocumentInvalid
>                  LxmlRegistryError
>                      NamespaceRegistryError
>                  LxmlSyntaxError(LxmlError, exceptions.SyntaxError)
>                      ParseError
>                          XMLSyntaxError
> 
> 
> Jose
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20141217/678a2912/attachment.sig>


More information about the Piglit mailing list